Repository navigation
fix(parser): accept CloudWatch Logs CONTROL_MESSAGE and keep extractedFields (#8869) - #8870
Open
dhairyakhandelwal880-dotcom wants to merge 1 commit into
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: closes #8869
Summary
Changes
aws_lambda_powertools/utilities/parser/models/cloudwatch.py:CloudWatchLogsDecode, madeowner,logGroup, andlogStreamoptional (str | None = None) and defaultedsubscriptionFiltersandlogEventstodefault_factory=list. When CloudWatch Logs emits aCONTROL_MESSAGE(e.g. to verify destination reachability), it sends only{"messageType": "CONTROL_MESSAGE"}.CloudWatchLogsLogEvent, addedextracted_fields: dict[str, str] = Field(default_factory=dict, alias="extractedFields")andmodel_config = ConfigDict(populate_by_name=True)so fields extracted by CloudWatch subscription filter patterns are preserved.aws_lambda_powertools/utilities/parser/envelopes/cloudwatch.py:CloudWatchLogsEnvelope.parse(), return an empty list[]whenparsed_envelope.awslogs.decoded_data.messageType == "CONTROL_MESSAGE".tests/unit/parser/_pydantic/test_cloudwatch.pycovering:CloudWatchLogsModelparsing of aCONTROL_MESSAGEevent.CloudWatchLogsEnvelopereturning[]onCONTROL_MESSAGE.CloudWatchLogsLogEventkeepingextractedFields.User experience
CONTROL_MESSAGEheartbeat.CloudWatchLogsEnvelopeis used with a schema model,CONTROL_MESSAGEevents gracefully return[]without error.extracted_fieldswhen subscription filter pattern extraction is used.Verification
Ran
pytest tests/unit/parser/_pydantic/test_cloudwatch.py(all 12 tests passed) and full parser test suite (all 203 tests passed). Verified formatting and linting withruff checkandruff format --check.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.