Repository navigation
fix(logger): route log, warn, and fatal through buffer dispatch - #8871
Open
dhairyakhandelwal880-dotcom wants to merge 1 commit into
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: closes #8827
Summary
Changes
_log()dispatcher.log(self, level, msg, *args, **kwargs)to route through the buffer and auto-flush on error log.warn = warningandfatal = criticalaliases._log().User experience
Before this change, calling
logger.log(),logger.warn(), orlogger.fatal()bypassed buffer routing and flush-on-error logic. Now they respectbuffer_at_verbosityand flush buffered logs upon error or critical log levels.Verification
tests/functional/logger/required_dependencies/test_powertools_logger_buffer.py:test_logger_log_method_buffers_and_flushes_on_errortest_logger_warn_and_fatal_aliasesruff check.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.