Repository navigation
fix(event-handler): set Vary: Accept-Encoding in compress middleware - #5888
Merged
Merged
Conversation
Responses that compress() could encode now list Accept-Encoding in Vary, whether or not the client accepts the encoding, so shared caches keep compressed and plain bodies apart. Existing Vary values are kept, duplicates are skipped, and Vary: * is left alone. The cors middleware uses the same helper, so it no longer overwrites an earlier Vary. Fixes #5886
Biome now places declare before access modifiers, likely after a Biome update.
svozza
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compress()setContent-Encodingbut neverVary, so shared caches such as CloudFront could serve a gzip body to a client that didn't ask for one. The middleware now addsAccept-EncodingtoVarywhenever the response could be compressed, keeping any value already there (for exampleOriginfromcors()). This matches the fix in aws-powertools/powertools-lambda-python#8711.Changes
compress()addsAccept-EncodingtoVarywhen the response qualifies for compression: when it's compressed, when the client doesn't accept the encoding, and onHEADrequests. It doesn't add it when compression was never possible whatever the client sent: below the threshold, already encoded,Cache-Control: no-transform, no body, or streaming.shouldCompresscheck is split into a response-only check (isCompressible), which decidesVary, and a request check (HEAD,Accept-Encoding), which decides compression.appendVaryHeaderhelper inmiddleware/commons.ts. It adds a field name to an existingVaryvalue, skips names already listed (ignoring case), and leavesVary: *untouched.cors()uses the same helper forOrigin, so it no longer overwrites aVaryset earlier.compress.test.tsandcors.test.tscover whenVaryis and isn't set, combining it with existing values, andcors()andcompress()together.advanced_compress_res.jsonnow includesVary, and the Compress section of the HTTP event handler docs describes the behaviour.public declare→declare public). Biome now reformats them, likely after a Biome update, and they'd otherwise fail the lint check in CI.Issue number: closes #5886
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.