Repository navigation
fix(metrics): skip non-finite metric values with a warning - #5963
Merged
dreamorosi merged 1 commit intoNov 13, 2026
Merged
dreamorosi merged 1 commit into
dreamorosi merged 1 commit into
Conversation
NaN, Infinity and -Infinity pass isNumber, so storeMetric stored them and JSON.stringify wrote them as null in the EMF line. storeMetric now logs a warning naming the metric and the value, and returns without storing it.
dreamorosi
approved these changes
Nov 13, 2026
dreamorosi
left a comment
Contributor
There was a problem hiding this comment.
Thank you for fixing this!
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NaN,Infinityand-InfinitypassisNumber, sostoreMetricstored them andJSON.stringifywrote them asnullin the EMF line. As agreed in #5961,storeMetricnow warns and skips the value, the same approach as aws-powertools/powertools-lambda-python#8797.Changes
storeMetricreturns without storing anything when!Number.isFinite(value), right after theisNumbercheck, and logs a warning with the metric name and the valueNaN,Infinityand-Infinitycheck the warning and that the EMF output only has the other metric from the same flushokis emitted as[1, 2])Issue number: closes #5961
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.