chore(cli-integ): pin integ test Node version to 24.19 - #1949
Merged
Conversation
Node >= 24.20.0 ships ada 4.0.0, which rejects the invalid URLs jsonschema builds during manifest validation. Published aws-cdk-lib bundles the unfixed cloud-assembly-schema, so every synth in integ tests crashes with "TypeError: Invalid URL". Restore 'lts/*' once aws-cdk-lib bundles a fixed cloud-assembly-schema.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
aws-cdk-automation
enabled auto-merge
September 7, 2026 11:50
rix0rrr
approved these changes
Sep 7, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1949 +/- ##
==========================================
- Coverage 91.33% 91.30% -0.04%
==========================================
Files 79 79
Lines 12164 12164
Branches 1721 1719 -2
==========================================
- Hits 11110 11106 -4
- Misses 1019 1023 +4
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aws-cdk-automation
deleted the
mrgrain/chore/cli-integ/pin-node-24-19
branch
September 7, 2026 12:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integ tests are failing on every synth with
TypeError: Invalid URLsince GitHub runners started resolvingnode-version: lts/*to Node.js 24.20.0 (see the init-templates failures). Node 24.20.0 ships the ada 4.0.0 URL parser, which correctly rejects the invalid URLs jsonschema builds while resolving local $refs during manifest validation (enabled in integ tests viaTESTING_CDK=1). The failing code lives in the publishedaws-cdk-lib, which bundles@aws-cdk/cloud-assembly-schemawith the unfixed jsonschema — so the patch merged in #1945 cannot reach it.This pins the integ test matrix Node version to 24.19 until a fixed
@aws-cdk/cloud-assembly-schemais released and re-bundled byaws-cdk-lib, at which point the pin should be reverted tolts/*. The prepare/build job keepslts/*since it builds this repo, which already carries the patch; the tool-integrations job keeps its existing Node 20 override.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license