Skip to content

chore(cli-integ): pin integ test Node version to 24.19 - #1949

Merged
aws-cdk-automation merged 1 commit into
mainfrom
mrgrain/chore/cli-integ/pin-node-24-19
Sep 7, 2026
Merged

chore(cli-integ): pin integ test Node version to 24.19#1949
aws-cdk-automation merged 1 commit into
mainfrom
mrgrain/chore/cli-integ/pin-node-24-19

Conversation

@mrgrain

@mrgrain mrgrain commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Integ tests are failing on every synth with TypeError: Invalid URL since GitHub runners started resolving node-version: lts/* to Node.js 24.20.0 (see the init-templates failures). Node 24.20.0 ships the ada 4.0.0 URL parser, which correctly rejects the invalid URLs jsonschema builds while resolving local $refs during manifest validation (enabled in integ tests via TESTING_CDK=1). The failing code lives in the published aws-cdk-lib, which bundles @aws-cdk/cloud-assembly-schema with the unfixed jsonschema — so the patch merged in #1945 cannot reach it.

This pins the integ test matrix Node version to 24.19 until a fixed @aws-cdk/cloud-assembly-schema is released and re-bundled by aws-cdk-lib, at which point the pin should be reverted to lts/*. The prepare/build job keeps lts/* since it builds this repo, which already carries the patch; the tool-integrations job keeps its existing Node 20 override.

Checklist

  • This change contains a major version upgrade for a dependency and I confirm all breaking changes are addressed
    • Release notes for the new version:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Node >= 24.20.0 ships ada 4.0.0, which rejects the invalid URLs
jsonschema builds during manifest validation. Published aws-cdk-lib
bundles the unfixed cloud-assembly-schema, so every synth in integ
tests crashes with "TypeError: Invalid URL".

Restore 'lts/*' once aws-cdk-lib bundles a fixed cloud-assembly-schema.
@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Sep 7, 2026
@mrgrain
mrgrain deployed to automation September 7, 2026 11:50 — with GitHub Actions Active
@mrgrain
mrgrain deployed to automation September 7, 2026 11:50 — with GitHub Actions Active
@github-actions github-actions Bot added the p2 label Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@aws-cdk-automation
aws-cdk-automation requested a review from a team September 7, 2026 11:50
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.30%. Comparing base (d4cb6e9) to head (da4a669).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1949      +/-   ##
==========================================
- Coverage   91.33%   91.30%   -0.04%     
==========================================
  Files          79       79              
  Lines       12164    12164              
  Branches     1721     1719       -2     
==========================================
- Hits        11110    11106       -4     
- Misses       1019     1023       +4     
  Partials       35       35              
Flag Coverage Δ
suite.unit 91.30% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation
aws-cdk-automation added this pull request to the merge queue Sep 7, 2026
Merged via the queue into main with commit bbd3018 Sep 7, 2026
27 checks passed
@aws-cdk-automation
aws-cdk-automation deleted the mrgrain/chore/cli-integ/pin-node-24-19 branch September 7, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants