feat(otel): add durable sampling coordination - #688
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
429f004 to
b37591b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
b37591b to
daabf76
Compare
Codex AI reviewOne resource-lifetime issue found. Residual risk: OTel 1.20 compatibility is simulated rather than tested against that version. Reviewed commit |
Claude AI reviewThis PR adds a self-contained OTel sampling-coordination module ( I reviewed the sampling decision logic, the OTel version-compatibility shim, trace-state propagation, attribute merging, context-key storage, and the tests. The implementation is careful and well-covered:
No blocking findings. No correctness, determinism, serialization, or concurrency defects warranting an inline comment were confirmed. Residual test risk / minor, non-blocking observations:
Reviewed commit |
daabf76 to
d4c905f
Compare
d4c905f to
52a82a5
Compare
|
/ai review |
Issue #, if available: #674
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.