Repository navigation
Relax message assertion for endpoint provider tests to avoid encoding issue - #7574
Merged
Merged
Conversation
zoewangg
approved these changes
Nov 19, 2026
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
If a service's endpoint rules include the region in the error message, it will show up as the encoded region (because we use
Region.of()). Service endpoint tests that assert against a non standard, non encoded region name will fail that test.For example, a service endpoint test expects "
us west 2is not a valid region" while the SDK generates "us%20west%202is not a valid region".Types of changes
Modifications
I made the assertion more lenient by treating decoded messages as correct as well.
Testing
Ran the endpoint provider tests or all service modules, and also ran the NetworkManager endpoint provider tests against the preview model that warranted this change. All pass.
AI tools
License