Repository navigation
Rename daemon_credential to credential_daemon; add aws.credentialDaemonSocket - #7575
Draft
GarrettBeatty wants to merge 2 commits into
Draft
GarrettBeatty wants to merge 2 commits into
GarrettBeatty wants to merge 2 commits into
Conversation
…onSocket Update the credential daemon provider to the latest shared settings: - The shared config key is now credential_daemon (previously daemon_credential), with no alias. - The socket path can be set with the aws.credentialDaemonSocket system property, checked before AWS_CREDENTIAL_DAEMON_SOCKET. It applies only when set to an absolute path; an empty or relative value counts as unset, and a failed dial does not fall back to another location. - Add an optional socketPath(Path) to the provider builder, checked first, with the same rules.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the credential daemon provider to the latest shared settings:
credential_daemon(previouslydaemon_credential). No alias, since the provider hasn't shipped.aws.credentialDaemonSocketsystem property, checked beforeAWS_CREDENTIAL_DAEMON_SOCKET. It applies only when set to an absolute path; empty or relative counts as unset. A set path with nothing listening fails withNOT_RUNNINGand doesn't fall back to a later location. The property is read on its own (not through the paired property/env lookup), so an empty or relative property doesn't hide the environment variable.socketPath(Path)on theCredentialDaemonCredentialsProviderbuilder, checked first, with the same rules.Tests:
./mvnw test -pl core/profiles,core/auth(with checkstyle) passes, and so doSsoOidcProfileTokenProviderFactoryTestandCredentialDaemonClientCallTestinservices/ssooidcandservices/sts.