Repository navigation
revert(runtime): flush tracing spans after invocations (#721) - #731
Merged
Merged
Conversation
This reverts commit 343da26. The flush made every response wait on the OTLP export. In VPC network mode without a route to X-Ray the export never connects, so streams stayed open until the client timed out. A repro on AgentCore Runtime found no microVM freeze after the response: a background thread kept running for 120 s in 9/9 runs, so BatchSpanProcessor's own export already covers the case #629 described. Reopens #629.
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
✅ No Breaking Changes DetectedNo public API breaking changes found in this PR. |
jariy17
had a problem deploying
to
auto-approve
November 3, 2026 17:56 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
aidandaly24
approved these changes
Nov 3, 2026
aidandaly24
left a comment
aidandaly24
left a comment
Contributor
There was a problem hiding this comment.
Tested it and it works well
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reverts #721 (343da26), which made
/invocationsresponses wait onTracerProvider.force_flush()before closing.Why
ReadTimeoutError). The sync stream path had no cap on the wait.BatchSpanProcessor) exportedThe microVM isn't frozen after the response; it keeps running until the idle timeout.
BatchSpanProcessor's normal 5 s export covers request spans without an explicit flush.Reopens #629 to find out what dropped spans in that environment.
Testing
pytest tests/bedrock_agentcore/runtime: 349 passedruff check/ruff format --check: clean