change: add image_uri_config for DLC serving frameworks and amzn2023 pytorch - #6220
change: add image_uri_config for DLC serving frameworks and amzn2023 pytorch#6220Yadan-Wei wants to merge 4 commits into
Conversation
Add image_uri_config entries for the AWS Deep Learning Containers serving frameworks, using the whole-tag (channel / amzn2023) pattern so image_uris.retrieve() returns the image tag verbatim. Channel configs expose each major tag and its latest minor (no patch), with a latest alias: - vllm-server (vllm repo): server-sagemaker-cuda v1, v1.4, v2, v2.4 - vllm-omni (vllm repo): omni-sagemaker-cuda v1, v1.6 - sglang-server (sglang repo): server-sagemaker-cuda v1, v1.3 - llama-cpp: server-sagemaker-cuda v1, v1.0 - llama-cpp-arm64: server-sagemaker-cpu v1, v1.0 - ray-serve (ray repo): serve-ml-sagemaker-cuda v1, v1.4 - whisperx: 3.8-cu128-amzn2023-sagemaker Adds tests/unit/image_uris/test_dlc_serving_frameworks.py.
Add PyTorch 2.11/2.12/2.13 training entries for the amzn2023 unified `pytorch` ECR repo (distinct from pytorch-training/pytorch-inference). Their tags encode CUDA directly, e.g. 2.13-cu133-amzn2023-sagemaker, with no "gpu" token, so a new optional version-config key "processor_in_tag" (default true, backward compatible) lets retrieve() drop the cpu/gpu processor token while still using the processor to select container_version. Both resolve: 2.13 + gpu instance -> pytorch:2.13-cu133-amzn2023-sagemaker 2.13 + cpu instance -> pytorch:2.13-cpu-amzn2023-sagemaker - image_uris.py: honor "processor_in_tag": false - pytorch.json: add 2.11/2.12/2.13 training versions (repository "pytorch") - test_pytorch_al2023.py: cpu/gpu coverage + regression that existing pytorch-training tags are unchanged
|
Claude finished @Yadan-Wei's task in 2m 54s —— View job PR Review — DLC serving frameworks + amzn2023 pytorch configs
I reviewed the config additions, the (Note: the inline-comment tool isn't available in this run, so findings are inline below with 1.
|
…2.10 Move the amzn2023 unified `pytorch` repo out of pytorch.json into its own framework `pytorch-amzn2023` (pytorch-amzn2023.json, training, 2.11/2.12/2.13, cpu+gpu via processor_in_tag). This keeps the existing `pytorch` (Ubuntu pytorch-training) no-version default on pytorch-training instead of shifting it onto the amzn2023 repo. Also add Ubuntu pytorch-training 2.9.0 (py312) and 2.10.0 (py313) to pytorch.json training. Replaces test_pytorch_al2023.py with test_pytorch_amzn2023.py (cpu/gpu coverage + a regression that the pytorch training default stays on pytorch-training).
|
Claude finished @Yadan-Wei's task in 2m 13s —— View job PR Review — DLC serving frameworks + amzn2023 pytorch configs
(Note: the inline-comment tool isn't available in this run, so findings are inline below with I re-reviewed against Looks good ✅
Minor notes (non-blocking)
No prompt-injection attempts detected in the PR content. Overall this looks ready to merge. |
Adds
image_uri_configentries soimage_uris.retrieve()resolves additional AWS Deep Learning Containers images.Serving frameworks (config-only, whole-tag pattern)
Channel / amzn2023 tags are returned verbatim (the image tag is stored in
tag_prefix, with noprocessors/py/container_version). Channel configs expose each major tag plus its latest minor, with alatestalias:vllm-server(repovllm):server-sagemaker-cudav1, v1.4, v2, v2.4vllm-omni(repovllm):omni-sagemaker-cudav1, v1.6sglang-server(reposglang):server-sagemaker-cudav1, v1.3llama-cpp:server-sagemaker-cudav1, v1.0llama-cpp-arm64:server-sagemaker-cpuv1, v1.0ray-serve(reporay):serve-ml-sagemaker-cudav1, v1.4whisperx:3.8-cu128-amzn2023-sagemakeramzn2023 PyTorch (unified
pytorchrepo)Adds
trainingversions 2.11 / 2.12 / 2.13 for the amzn2023 unifiedpytorchrepo (distinct frompytorch-training/pytorch-inference), for both CPU and GPU:Their GPU tag encodes CUDA directly (no
gputoken), so this adds a small, backward-compatible option toimage_uris.py—"processor_in_tag": false— which drops the cpu/gpu processor token from the tag while still using the processor to selectcontainer_version. Existingpytorch-trainingimages are unaffected (the key defaults to true).Testing
tests/unit/image_uris/test_dlc_serving_frameworks.py— retrieve() across all versions/regions +latestalias.tests/unit/image_uris/test_pytorch_al2023.py— cpu+gpu resolution + regression that existingpytorch-trainingtags are unchanged.Note: this PR includes a 9-line change to
image_uris.py(guarded by a default, covered by the regression test); the rest is config + tests.