Skip to content

Do not read trailing comments for a first-line expression #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not read trailing comments for a first-line expression #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62b73c8
Do not read trailing comments for a first-line expression
OskarEichler Aug 27, 2026
8bb7e4b
Add regression coverage for do not read trailing comments for a first…
OskarEichler Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/method_source/code_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def expression_at(file, line_number, options={})
def comment_describing(file, line_number)
lines = file.is_a?(Array) ? file : file.each_line.to_a

extract_last_comment(lines[0..(line_number - 2)])
extract_last_comment(lines[0, line_number - 1])
end

# Determine if a string of code is a complete Ruby expression.
Expand Down
5 changes: 5 additions & 0 deletions spec/method_source/code_helpers_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
@tester = Object.new.extend(MethodSource::CodeHelpers)
end

it "does not read trailing comments for a first-line expression" do
lines = ["def first; end\n", "# unrelated tail\n"]
expect(@tester.comment_describing(lines, 1)).to eq("")
end

[
["p = '", "'"],
["def", "a", "(); end"],
Expand Down