Skip to content

Recognize incomplete Prism command-string delimiters #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Recognize incomplete Prism command-string delimiters #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
665b0b4
Recognize incomplete Prism command-string delimiters
OskarEichler Aug 27, 2026
e5213f1
Add regression coverage for recognize incomplete prism command-string…
OskarEichler Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/method_source/code_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ module IncompleteExpression
/embedded document meets end of file/, # =begin
/unterminated (quoted string|string|regexp|list) meets end of file/, # "quoted string" is ironruby
/can't find string ".*" anywhere before EOF/, # rbx and jruby
/expected a closing delimiter for the `%x` or backtick string/, # prism
/missing 'end' for/, /expecting kWHEN/ # rbx
]

Expand Down
5 changes: 5 additions & 0 deletions spec/method_source/code_helpers_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
@tester = Object.new.extend(MethodSource::CodeHelpers)
end

it "recognizes incomplete command-string delimiters" do
expect(@tester.complete_expression?("%x[word")).to be_falsy
expect(@tester.complete_expression?("`word")).to be_falsy
end

[
["p = '", "'"],
["def", "a", "(); end"],
Expand Down