Refactor completions as native runtime functions - #721
Merged
Conversation
…neration is enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #657
This PR replaces Bashly's Completely-based completion generation with native runtime completion functions embedded in the generated Bash script.
The generated CLI therefore remains the single source of truth for command, argument, and flag behavior. Shell completion wrappers can remain small and static while automatically reflecting changes made to the CLI.
Philosophy
yourcli __completecommand that returns the valid candidates for an incomplete command line.yourcli __completeand consume its response.bashly add completions, starting with Bash and potentially extending to Zsh and Fish.Advantages
Disadvantages
TODO
bashly completions --installsince it needs Completelybashly add completionsin favor of internal native function generationcompletionsdirective inbashly.yml