Repository navigation
End Search Natives that got no backend connection as not started - #168
Merged
Merged
Conversation
A Search Native that fails while connecting or during the TLS handshake never wrote a byte, so the backend never saw it. Report it NOT_STARTED with its UNAVAILABLE failure, which clients may resend whatever the method, instead of RESPONSE_INCOMPLETE, which reads as possibly applied.
Only advance the exchange phase, read it once, and note that not started is true only while the Native transport never reuses a connection. Cover a deadline before the connection, an untrusted certificate, an unresolvable host and a late handshake, and document deadlines while connecting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production PSE search reads occasionally fail with "Native HTTP exchange incomplete while connecting (timeout)" in short bursts, and only PSE's own read path resends them. A Native that never got a connection wrote nothing, so the backend never saw it; reporting it NATIVE_NOT_STARTED with its UNAVAILABLE failure says so, and weir-go then resends it like any other refused call, whatever the request method. Failures after the transport handed over a connection still end RESPONSE_INCOMPLETE, since request bytes may have arrived.