Skip to content

allinone: install Python packages into a venv - #180

Merged
dhalperi merged 1 commit into
masterfrom
fix-allinone-packaging
Oct 26, 2026
Merged

dhalperi merged 1 commit into
masterfrom
fix-allinone-packaging

Conversation

@dhalperi

@dhalperi dhalperi commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

virtualenv 21.14.13, pulled in via pybatfish's pre-commit dev dep,
requires packaging>=26.3. The allinone image had packaging 26.0 from
apt (python3-pip -> python3-wheel -> python3-packaging), and pip
failed with uninstall-no-record-file when it tried to upgrade it.

Install pybatfish, Jupyter, and the rest into /opt/venv, which is on
PATH, after upgrading pip, setuptools, and wheel there. Drop
python3-pip and python3-wheel from the apt packages. pip in the image
no longer needs --break-system-packages.

@batfish-bot

Copy link
Copy Markdown

This change is Reviewable

@dhalperi
dhalperi force-pushed the fix-allinone-packaging branch from 500d776 to dd1dab7 Compare October 26, 2026 15:33
@dhalperi dhalperi changed the title tests: shadow apt packaging before installing pybatfish dev deps allinone: install Python packages into a venv Oct 26, 2026
virtualenv 21.14.13, pulled in via pybatfish's pre-commit dev dep,
requires packaging>=26.3. The allinone image had packaging 26.0 from
apt (python3-pip -> python3-wheel -> python3-packaging), and pip
failed with uninstall-no-record-file when it tried to upgrade it.

Install pybatfish, Jupyter, and the rest into /opt/venv, which is on
PATH, after upgrading pip, setuptools, and wheel there. Drop
python3-pip and python3-wheel from the apt packages. pip in the image
no longer needs --break-system-packages.
@dhalperi
dhalperi force-pushed the fix-allinone-packaging branch from dd1dab7 to b06bbdb Compare October 26, 2026 16:09

@dhalperi dhalperi left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhalperi reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dhalperi).

@dhalperi
dhalperi merged commit 3f13f8a into master Oct 26, 2026
14 checks passed
@dhalperi
dhalperi deleted the fix-allinone-packaging branch October 26, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants