ci: retain security reports as workflow artifacts - #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/upload-artifactto the immutable v7.0.1 commitWhy
The security jobs already generated and validated machine-readable reports, but those files disappeared with the runner workspace. Reviewers and maintainers could see only the job result, not retrieve the exact reports produced by a specific run.
This change publishes the validated JSON files directly from their producer jobs without adding an aggregation job, cross-job downloads, repository write permission, or project secrets.
Artifact contract
Static analysis
Artifact:
static-analysis-reports-${{ github.run_attempt }}Contents:
reports/ci/static-analysis-src.jsonreports/ci/static-analysis-tools.jsonreports/ci/static-analysis-sample-app.jsonDependency scan
Artifact:
dependency-scan-report-${{ github.run_attempt }}Contents:
reports/ci/dependency-scan.jsonFailure and security behavior
-sbefore uploadif-no-files-found: errorprovides a second fail-closed guardcontents: readcontinue-on-erroris not usedValidation
1000 passed19 passed1000 passed16 passedgit diff --check: passedPublished artifact verification
Run #9 published exactly two non-expired artifacts for head
0dc3b5974d588e4a616cd12037544dd6326dfa8d:static-analysis-reports-1sha256:63a483ab193f221344963c300989559eabee8e63a18663fb0eb484b15b52cdd3dependency-scan-report-1reports/ci/dependency-scan.jsonand exactly 1 filesha256:eedfb94a1dcac1fd42cc194c1db2eefa96872a368359115c69360315ba0cf4f6Follow-up
Backlog 5.5 will complete remaining test coverage and whole-project self-analysis work.