Make "Delete subscribers" work on multisite

[cs1m0n]

Problem

"Delete subscribers" (Settings → BCC Login → Maintenance) built the users and usermeta table names from the site's table prefix. On a network those tables are shared by all sites:

• On a subsite it queried wp_N_users, which doesn't exist, so nothing was deleted ("The subscribers could not be deleted").
• On the main site it deleted every user whose only role on the main site was subscriber from the whole network, including users with roles on other sites.

Changes

It now uses $wpdb->users and $wpdb->usermeta, with this site's capabilities key.

• Single site: unchanged, the subscribers' accounts are deleted.
• Network:
  • Subscribers who have a role on another site, or are listed there without one, keep their account and only leave this site, as when WordPress removes a user from a site. The others are deleted.
  • Only network administrators can delete accounts on a network. When a site administrator presses the button, subscribers only leave the site.
  • Network administrators are left alone, whatever their role on the site.
  • With OIDC_CREATE_USERS on, nobody only leaves a site. The login can't add an existing account back to a site, so those users couldn't log in there again. They're kept until their account can be deleted, and the message says so.
• If a lookup query fails, nothing is changed and the error notice is shown. Accounts are deleted before anyone leaves the site, so if deleting fails they're still subscribers and pressing again finds them.
• A note under the button explains the network behaviour.

Testing

In throwaway WordPress 7.0.2 sites on PHP 7.4:

• Single site: subscribers (including the plugin's own bcc-login-subscriber) are deleted with their meta. The administrator, the editor and bcc-login-member stay. The message is unchanged. When the lookup fails, nothing changes and the error is shown.
• Network of two sites:
  • The site administrator of site two removed its subscribers from that site without deleting any account, and left a network administrator who was a subscriber there alone.
  • The network administrator on the main site deleted the subscribers with no other role. A user who is an editor on site two only left the main site.
  • With OIDC_CREATE_USERS on, the network administrator deleted the subscribers with no other site and kept the two who also belong to site two. The site administrator kept everyone.
  • When the membership query fails, nothing changes and the error is shown.

PHPStan with the CI config passes, and php -l passes on PHP 7.4 and 8.4.

🤖 Generated with Claude Code

[Copilot]

🟡 Changes recommended

Raw database deletion bypasses WordPress user-removal lifecycles and can leave inconsistent metadata, content, caches, and integrations.

2 open findings

• Use WordPress user deletion APIs to preserve cleanup and hooks · New
• Clarify subscriber retention when OIDC user creation is enabled · New

What changed in this PR

Updates subscriber maintenance for WordPress multisite installations.

Changes:

• Uses shared network user tables and site-specific capabilities.
• Distinguishes account deletion, site removal, and retained users.
• Adds multisite-specific notices and reporting.

File	Description
plugins/​bcc-login/​includes/​class-bcc-login-settings.php	Implements multisite subscriber lookup, deletion, removal, and messaging.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.