Skip to content

docs: restore README setup steps for OpenShift tokens and secrets - #2905

Merged
DerekRoberts merged 2 commits into
mainfrom
docs/deploy-account-by-hand
Oct 21, 2026
Merged

DerekRoberts merged 2 commits into
mainfrom
docs/deploy-account-by-hand

Conversation

@DerekRoberts

@DerekRoberts DerekRoberts commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

The README lost its by-hand setup instructions (service account, role binding, OC_TOKEN, OC_NAMESPACE, DB_PASSWORD) in #2887, leaving only the setup scripts.

  • Restores the removed Secret Values content from before feat(scripts): setup scripts for GitHub and OpenShift #2887, close to verbatim, as Secrets and Variables by Hand: repository-level vs environment values, where to create secrets and environments, the OC_TOKEN steps (oc create sa, oc create rolebinding, oc create token --duration=87600h), OC_NAMESPACE and DB_PASSWORD guidance.
  • Updates only what has changed since: OC_NAMESPACE is now a variable (vars.OC_NAMESPACE), plus gh secret set / gh variable set commands and OC_SERVER.
  • Marks the setup scripts (checklist steps 5 and 6) as an optional helper, linking to the by-hand steps.

Copilot AI balanced review requested due to automatic review settings October 21, 2026 03:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The token-transfer command needs a readiness check to avoid uploading empty input before OpenShift populates the token.

1 open issue
What changed in this PR

Restores manual OpenShift deployment-account setup alongside the existing setup scripts.

Changes:

  • Documents service-account creation, permissions, and token setup using script-compatible names.
  • Explains GitHub secret and variable configuration for DEV, TEST, and PROD.
  • Clarifies that pull requests deploy to <plate>-dev.
File Description
README.md Adds manual deployment-account and environment configuration instructions.

Review effort: Balanced

Comment thread README.md Outdated
@DerekRoberts DerekRoberts changed the title docs: restore OpenShift deploy account steps by hand docs: restore README setup steps for OpenShift tokens and secrets Oct 21, 2026
@DerekRoberts DerekRoberts self-assigned this Oct 21, 2026
@DerekRoberts
DerekRoberts merged commit 2e4992d into main Oct 21, 2026
24 of 26 checks passed
@DerekRoberts
DerekRoberts deleted the docs/deploy-account-by-hand branch October 21, 2026 03:52
@github-project-automation github-project-automation Bot moved this from New to Done in DevOps (NR) Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants