Repository navigation
docs: restore README setup steps for OpenShift tokens and secrets - #2905
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The token-transfer command needs a readiness check to avoid uploading empty input before OpenShift populates the token.
1 open issue
What changed in this PR
Restores manual OpenShift deployment-account setup alongside the existing setup scripts.
Changes:
- Documents service-account creation, permissions, and token setup using script-compatible names.
- Explains GitHub secret and variable configuration for DEV, TEST, and PROD.
- Clarifies that pull requests deploy to
<plate>-dev.
| File | Description |
|---|---|
| README.md | Adds manual deployment-account and environment configuration instructions. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The README lost its by-hand setup instructions (service account, role binding, OC_TOKEN, OC_NAMESPACE, DB_PASSWORD) in #2887, leaving only the setup scripts.
OC_TOKENsteps (oc create sa,oc create rolebinding,oc create token --duration=87600h),OC_NAMESPACEandDB_PASSWORDguidance.OC_NAMESPACEis now a variable (vars.OC_NAMESPACE), plusgh secret set/gh variable setcommands andOC_SERVER.