fix: avoid Pydantic namespace shadowing in Message.parse - #254
Open
AndersonBY wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated Pydantic dataclasses can use a module-level
dataalias for nested enums.Message.parse(data)currently keeps its bytes parameter in the local frame while constructing the dataclass; Pydantic lazy forward-reference resolution can then resolvedata.SomeEnumagainstbytesand fail on a legal payload.This patch deletes the parameter after creating the BytesIO stream, before constructing the message. It preserves positional and keyword call compatibility and adds regression coverage for both forms using the generated-module shape.
Validated on Python 3.12 with the 0.9.1 library source and Pydantic 2.13.x.