Skip to content

feat(test): track when running process ends during bitcoin-cli stop - #2579

Open
bitcoin-tools wants to merge 14 commits into
masterfrom
2578-feat---improve-the-test_nodebuilder-bitcoin-cli-stop-process
Open

feat(test): track when running process ends during bitcoin-cli stop#2579
bitcoin-tools wants to merge 14 commits into
masterfrom
2578-feat---improve-the-test_nodebuilder-bitcoin-cli-stop-process

Conversation

@bitcoin-tools

Copy link
Copy Markdown
Owner

Refactor Bitcoin Core stopping logic to improve clarity and reliability.

Describe the changes and your approach

Pull Request Sign-Off

  • I reviewed and approve of my changes.
  • I checked of the automated test results for any irregularities.
  • If appropriate, I manually tested the code changes on my local environment.
  • If appropriate, I considered changes to the README or test documentation.

Refactor Bitcoin Core stopping logic to improve clarity and reliability.
@bitcoin-tools bitcoin-tools changed the title feat(test): track running process instead of pidfile during stop feat(test): during bitcoin-cli stop, track when running process ends Aug 28, 2026
@bitcoin-tools bitcoin-tools changed the title feat(test): during bitcoin-cli stop, track when running process ends feat(test): track when running process ends during bitcoin-cli stop Aug 28, 2026
@bitcoin-tools

Copy link
Copy Markdown
Owner Author
+ bitcoin_pname=bitcoind
runner            3221   0.0  0.1 435304560   5024   ??  S<    2:23PM   0:00.01 caffeinate -sw 3211
+ '[' bitcoind = bitcoind ']'
+ sleep 2
+ bitcoin_stop_sleep_elapsed=8
+ ps aux
+ grep 3211
runner            6362   0.0  0.0 435298848   1488   ??  S<    2:26PM   0:00.00 grep 3211
+ '[' 8 -ge 3600 ']'
++ ps -p 3211 -o comm=
+ bitcoin_pname=
+ '[' 1 -eq 0 ']'
+ handle_error
+ handle_exit
+ kill_tail_process
+ kill -0 1828
+ '[' false = true ']'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] - improve the test_nodebuilder bitcoin-cli stop process

1 participant