Repository navigation
Support ephemeral Gateway identity and state cleanup [KPL-118] - #24
Draft
terraboops wants to merge 4 commits into
Draft
terraboops wants to merge 4 commits into
terraboops wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disposable preview Gateways currently leave durable tailnet identity and state storage behind. Add
tsjwt.dev/ephemeral: "true"to opt into ephemeral auth keys/tsnet identity and PVC deletion when the Gateway's StatefulSet is removed. Unannotated Gateways preserve their current behavior.The controller passes the new data-plane flag and reconciles PVC retention. Tailscale performs best-effort logout on graceful shutdown; forced shutdown relies on its offline cleanup timeout. This is a prerequisite for Kploy's per-PR tsjwt routing.
CI also found a reachable vulnerability in the existing indirect klauspost/compress dependency (GO-2026-6865). Both standalone module graphs are updated to the scanner-identified fixed version v1.20.2. Once that stopped masking the Gateway scan, it exposed five reachable HTTP/2 findings in golang.org/x/net; the Gateway graph now uses the reported fixed version v0.60.0 and its required golang.org/x dependencies.
Validation:
go test -race ./...andgo vet ./...in gateway pass, including ephemeral/durable provisioning and distinct preview issuer/audience contracts. Local govulncheck using CI's Go 1.26.10 now reports no reachable vulnerabilities in the auth-key and Gateway modules. Real-tailnet shutdown/recreate still needs rollout validation.Release this support before enabling kploy tsjwt previews. The deployment draft will reference v0.9.6; adjust that target if another version is released first.
Part of KPL-118: https://linear.app/bit-complete/issue/KPL-118
Linked integration: https://github.com/bitcomplete/kploy/pull/242
Deployment prerequisite: https://github.com/bitcomplete/tsjwt-deploy/pull/23