Repository navigation
Remove unused npm dependencies - #101
Merged
Merged
Conversation
The root run-sequence, @types/mkdirp and @types/assert packages are not used: there is no gulpfile, mkdirp ships its own types, and @types/node covers assert. The testing framework declared superagent, superagent-proxy, uuid, base-64, mocha-junit-reporter and a second mocha that its scripts never load. superagent-proxy alone pulled in vm2, ip, pac-resolver and socks, and superagent pulled in form-data and formidable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the development and testing dependency cleanup.
No open issues 🎉
What changed in this PR
This PR trims unused dependencies from React Native CodePush’s development tooling and testing framework without changing runtime code.
Changes:
- Removes unused root tooling and redundant type packages.
- Removes unused testing-framework packages, including HTTP clients, proxy support, and reporting utilities.
- Updates the lockfile to remove the packages and their unused transitive dependencies.
| File | Description |
|---|---|
package.json |
Removes run-sequence, @types/mkdirp, and @types/assert. |
package-lock.json |
Synchronizes dependency removals and prunes unused transitive packages. |
code-push-plugin-testing-framework/package.json |
Removes unused dependencies, retaining q and replace. |
Review effort: Balanced
gsanta
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops npm dependencies that nothing in the repo imports or runs. It cuts the lockfile by 91 packages and removes a few deprecated or vulnerable ones from the install tree.
What goes
Root
package.json(dev dependencies):run-sequence: there is no gulpfile.@types/mkdirp:mkdirpships its own types.@types/assert:@types/nodealready coversassert.code-push-plugin-testing-framework:superagent,superagent-proxy,uuid,@types/uuid,base-64,mocha-junit-reporter, and a second copy ofmocha. No test code or npm script loads them, and the rootmochais the one that runs.superagent-proxyalone pulled invm2,ip,pac-resolverandsocks.superagentpulled inform-dataandformidable, and npm flags the pinnedsuperagent@6as deprecated over aformidablevulnerability.qandreplacestay in the testing framework because the E2E tests still use them.replaceis pinned tolatest, which I left alone to keep this PR to removals.