Repository navigation
Build the bare Android E2E app with resource shrinking - #105
Merged
Merged
Conversation
The generated app used the React Native template defaults, which leave R8 and resource shrinking off. AGP 9 turns on the optimized resource shrinker, which removes resources the SDK looks up by name. E2E could not catch that. Enable minify and shrinkResources so it does. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The edits target a runtime-generated RN 0.88 Gradle template not checked in, and bare Android E2E validation after #100 merges is still needed to confirm the replacements and resource retention with shrinking enabled.
No open issues 🎉
What changed in this PR
Updates the existing bare Android E2E app to exercise release builds with R8 and resource shrinking, helping detect removal of resources CodePush resolves by name. This complements the resource keep rules in #100.
Changes:
- Enables release minification and resource shrinking in the generated bare Android app.
- Uses the existing E2E job; Expo remains unchanged.
| File | Description |
|---|---|
test/test.mts |
Updates generated Gradle settings to enable minification and resource shrinking. |
Review effort: Balanced
ofalvai
marked this pull request as ready for review
November 3, 2026 12:17
gsanta
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bare Android E2E app builds with the React Native template defaults, which leave R8 and resource shrinking off. AGP 9 turns on the optimized resource shrinker, and it removes resources the SDK looks up by name. E2E could not see that, which is how #100 went unnoticed.
This turns on
minifyEnabledandshrinkResourcesfor the generated bare app. It adds no CI job. The existing bare Android job now tests the shrunk build. The Expo variant is unchanged.