Skip to content

fix(android): accept downloads without Content-Length #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofalvai merged 1 commit into from
Nov 5, 2026
Merged

fix(android): accept downloads without Content-Length #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion android/app/src/main/java/com/microsoft/codepush/react/CodePushUpdateManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,10 @@ public void downloadPackage(JSONObject updatePackage, String expectedBundleFileN
progressCallback.call(new DownloadProgress(totalBytes, receivedBytes));
}

if (totalBytes != receivedBytes) {
// getContentLength() returns -1 when the response has no Content-Length (e.g. a proxy
// re-chunked it), so only compare when the length is known. A truncated chunked
// response still fails with an IOException in the read loop above.
if (totalBytes >= 0 && totalBytes != receivedBytes) {
Comment thread
ofalvai marked this conversation as resolved.
Resolved
throw new CodePushUnknownException("Received " + receivedBytes + " bytes, expected " + totalBytes);
}

Expand Down
Loading