Skip to content

test: remove duplicate diff E2E test and unused isDiff flag - #115

Open
ofalvai wants to merge 1 commit into
masterfrom
remove-duplicate-diff-e2e
Open

ofalvai wants to merge 1 commit into
masterfrom
remove-duplicate-diff-e2e

Conversation

@ofalvai

@ofalvai ofalvai commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

The “diff against binary” E2E test creates a full update and repeats the immediate-install test's assertions, so its name implies coverage it does not provide.

Remove the duplicate test and the unused isDiff plumbing, including the synthetic diff manifest and signing bypass. Binary diff behavior remains covered by unit tests; adding binary diff E2E coverage is outside this change's scope.

Copilot AI balanced review requested due to automatic review settings November 10, 2026 20:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The test-harness cleanup has no active review issues.

No open issues 🎉

What changed in this PR

This PR cleans up the CodePush test harness by removing a misleading “diff against binary” E2E test that duplicates full-update coverage. It removes unused diff-specific plumbing without changing runtime update behavior.

Changes:

  • Removes the duplicate E2E test while retaining the immediate-install test.
  • Removes isDiff parameters from archive helpers and their declarations.
  • Removes synthetic diff-manifest generation and the diff-specific signing bypass.
File Description
test/​test.mts Removes the duplicate test and unused diff arguments.
test/​codesign.mts Removes the signing bypass and updates the archive call.
code-push-plugin-testing-framework/​typings/​code-push-plugin-testing-framework.d.ts Aligns helper declarations with the simplified signatures.
code-push-plugin-testing-framework/​script/​testUtil.js Removes the diff flag and synthetic manifest generation.
code-push-plugin-testing-framework/​script/​projectManager.js Removes the unused parameter from the base archive method.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants