Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The test-harness cleanup has no active review issues.
No open issues 🎉
What changed in this PR
This PR cleans up the CodePush test harness by removing a misleading “diff against binary” E2E test that duplicates full-update coverage. It removes unused diff-specific plumbing without changing runtime update behavior.
Changes:
- Removes the duplicate E2E test while retaining the immediate-install test.
- Removes
isDiffparameters from archive helpers and their declarations. - Removes synthetic diff-manifest generation and the diff-specific signing bypass.
| File | Description |
|---|---|
test/test.mts |
Removes the duplicate test and unused diff arguments. |
test/codesign.mts |
Removes the signing bypass and updates the archive call. |
code-push-plugin-testing-framework/typings/code-push-plugin-testing-framework.d.ts |
Aligns helper declarations with the simplified signatures. |
code-push-plugin-testing-framework/script/testUtil.js |
Removes the diff flag and synthetic manifest generation. |
code-push-plugin-testing-framework/script/projectManager.js |
Removes the unused parameter from the base archive method. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The “diff against binary” E2E test creates a full update and repeats the immediate-install test's assertions, so its name implies coverage it does not provide.
Remove the duplicate test and the unused
isDiffplumbing, including the synthetic diff manifest and signing bypass. Binary diff behavior remains covered by unit tests; adding binary diff E2E coverage is outside this change's scope.