Skip to content

feat: show page sort sortName in list and warn when an upgrade changes it - #174

Merged
Rinse12 merged 1 commit into
masterfrom
feat/page-sort-sortname
Oct 20, 2026
Merged

Rinse12 merged 1 commit into
masterfrom
feat/page-sort-sortname

Conversation

@Rinse12

@Rinse12 Rinse12 commented Oct 20, 2026

Copy link
Copy Markdown
Member

The two sortName items from #138 that the first page-sort release (#172) left out. A package's sortName is the key it publishes under in pageCids, and it need not match the package name.

page-sort list loads each package with validatePageSortFileFactory (the same check install runs) and prints the sortName:

<dataPath>/page-sorts
├── broken-page-sort@0.1.0 (failed to load: broken page sort)
└── test-page-sort@1.0.0 (sortName: fromPackage)

A package that fails to load is reported in place, and the rest are still listed. list -q is unchanged and prints names only.

page-sort install reads the sortName of the copy being replaced before the swap, and warns when the new version changes it:

changed demo-sort@2.0.0 in 1s
 ›   Warning: demo-sort changed its sortName from "demo" to "demo2".
 ›   Communities using it now publish these pages under "demo2", and clients
 ›   asking for "demo" will not find them.

If the old copy no longer loads, the comparison is skipped, so a broken install can't block the upgrade that fixes it.

Tests are in test/cli/page-sort.test.ts: sortName in list, a broken package next to a working one, and upgrades with a changed and an unchanged sortName. Full suite: 400 passed.

Closes #173

@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f7b9b7ff-4c98-42cd-a459-a35a26ab6eb6
📥 Commits

Reviewing files that changed from the base of the PR and between fc506f1 and 31e2cd0.

📒 Files selected for processing: 4
  • src/cli/commands/page-sort/install.ts
  • src/cli/commands/page-sort/list.ts
  • src/page-sort-packages/page-sort-utils.ts
  • test/cli/page-sort.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T07:21:50.603557Z 31e2cd0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Rinse12
Rinse12 merged commit af814b0 into master Oct 20, 2026
4 checks passed
@Rinse12
Rinse12 deleted the feat/page-sort-sortname branch October 20, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

page-sort: show sortName in list and warn when an upgrade changes it

1 participant