Repository navigation
feat: show page sort sortName in list and warn when an upgrade changes it - #174
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The two
sortNameitems from #138 that the firstpage-sortrelease (#172) left out. A package'ssortNameis the key it publishes under inpageCids, and it need not match the package name.page-sort listloads each package withvalidatePageSortFileFactory(the same checkinstallruns) and prints thesortName:A package that fails to load is reported in place, and the rest are still listed.
list -qis unchanged and prints names only.page-sort installreads thesortNameof the copy being replaced before the swap, and warns when the new version changes it:If the old copy no longer loads, the comparison is skipped, so a broken install can't block the upgrade that fixes it.
Tests are in
test/cli/page-sort.test.ts:sortNameinlist, a broken package next to a working one, and upgrades with a changed and an unchangedsortName. Full suite: 400 passed.Closes #173