Skip to content

chore(deps): upgrade @pkcprotocol/pkc-js to 0.0.118 - #180

Merged
Rinse12 merged 1 commit into
masterfrom
chore/upgrade-pkc-js-0.0.118
Oct 21, 2026
Merged

Rinse12 merged 1 commit into
masterfrom
chore/upgrade-pkc-js-0.0.118

Conversation

@Rinse12

@Rinse12 Rinse12 commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Closes #179

Upgrades @pkcprotocol/pkc-js from 0.0.115 to 0.0.118 (exact pin). All three releases are bug fixes:

Changes for pkc-js#429

  • test/cli/challenge-integration.test.ts: the fix: refuse challenge remove while a community's settings.challenges still uses the package #177 e2e test that removes a challenge a community still uses now checks the new behavior:
    • the publish reason is One of the community challenges is misconfigured: challenge "<name>" is not registered on this node;
    • restarting fails with ERR_COMMUNITY_CHALLENGES_FAILED_TO_LOAD (it was an unnamed Zod error).
      On 0.0.118 the test failed, as its comment expected, before this update.
  • docs/challenges.md:
    • "Removing" quotes the new messages, and says a running community stays up until it restarts.
    • New troubleshooting entry for ERR_COMMUNITY_CHALLENGES_FAILED_TO_LOAD: which error details to read (details.failures, details.availableChallengeNames) and how to recover (reinstall, or community edit, then community start).

The challenge remove refusal and --force warning text is still accurate, so src/ is unchanged.

Verification

npm run build && npm run build:test and npm run test:cli pass: 50 files, 409 tests, 1 skipped.

Summary by CodeRabbit

  • Documentation

    • Added troubleshooting guidance for startup failures caused by missing challenge registrations.
    • Documented the ERR_COMMUNITY_CHALLENGES_FAILED_TO_LOAD error, diagnostic details, and recovery steps.
  • Bug Fixes

    • Improved error reporting when a community cannot load a required challenge package.
    • Publication failures now identify the missing challenge, making configuration issues easier to diagnose.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T16:26:47.719978Z 40c0405 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0c656f3b-7a73-4f30-b8e9-bc22907bf182
📥 Commits

Reviewing files that changed from the base of the PR and between 8db805a and 40c0405.

⛔ Files ignored due to path filters: 1
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing: 3
  • docs/challenges.md
  • package.json
  • test/cli/challenge-integration.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The project now uses @pkcprotocol/pkc-js 0.0.118. The integration test checks missing-challenge publish and startup errors. The documentation describes the errors and recovery steps.

Changes: Challenge loading error

Layer / File(s) Summary
Dependency, assertions, and troubleshooting
package.json, test/cli/challenge-integration.test.ts, docs/challenges.md
The dependency is updated to 0.0.118. The integration test checks that a publish failure names the missing challenge and that restarting returns ERR_COMMUNITY_CHALLENGES_FAILED_TO_LOAD. The documentation describes the error and recovery commands.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 40c04

The dependency upgrade and related test and documentation changes show no merge-blocking risk.

Pre-merge checks: Passed 4 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Linked Issues check Inconclusive The reviewed changes match #179: package.json updates @pkcprotocol/pkc-js to 0.0.118, the integration test checks the named challenge and ERR_COMMUNITY_CHALLENGES_FAILED_TO_LOAD, and `docs/cha… Provide reviewable evidence that the full test suite passed and confirm the exact dependency pin in the excluded package-lock.json, or state why the reported test:cli command is the full required suite.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the primary change: upgrading the @pkcprotocol/pkc-js dependency to version 0.0.118.
Out of Scope Changes check Passed The dependency update, challenge integration test changes, and documentation changes directly implement #179. The three upstream bug-fix releases are within the linked issue scope. No unrelated change…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Full details: Out of Scope Changes check

Explanation

The dependency update, challenge integration test changes, and documentation changes directly implement #179. The three upstream bug-fix releases are within the linked issue scope. No unrelated change is identified in the reviewed summary.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)

Full details: Linked Issues check

Explanation

The reviewed changes match #179: package.json updates @pkcprotocol/pkc-js to 0.0.118, the integration test checks the named challenge and ERR_COMMUNITY_CHALLENGES_FAILED_TO_LOAD, and docs/challenges.md adds the required behavior and recovery guidance. The reported verification runs npm run build, npm run build:test, and npm run test:cli, but the evidence does not establish that the full test suite ran. package-lock.json is excluded from review, so its installation and exact-pin state cannot be independently verified.

Resolution

Provide reviewable evidence that the full test suite passed and confirm the exact dependency pin in the excluded package-lock.json, or state why the reported test:cli command is the full required suite.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

package.json

Oops! Something went wrong! :(

ESLint: 8.27.0

Error: ESLint configuration in --config » eslint-config-oclif is invalid:

  • Unexpected top-level property "__esModule".

Referenced from: /.eslintrc
at ConfigValidator.validateConfigSchema (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2156:19)
at ConfigArrayFactory._normalizeConfigData (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2998:19)
at ConfigArrayFactory._loadConfigData (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2963:21)
at ConfigArrayFactory._loadExtendedShareableConfig (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3264:21)
at ConfigArrayFactory._loadExtends (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3135:25)
at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3074:25)
at _normalizeObjectConfigDataBody.next ()
at ConfigArrayFactory._normalizeObjectConfigData (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3019:20)
at _normalizeObjectConfigData.next ()
at ConfigArrayFactory.loadFile (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2829:16)

test/cli/challenge-integration.test.ts

ESLint skipped: the matched ESLint configuration already failed (config-incompatibility).

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Rinse12
Rinse12 merged commit fc6257d into master Oct 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(deps): upgrade @pkcprotocol/pkc-js to 0.0.118

1 participant