Repository navigation
perf(staged): poll child session badges for their title only - #1011
Merged
Merged
Conversation
Running children of a project session rode along in the live hint poller as full trackers, so each one cost a transcript fetch per 750 ms tick on top of the `getSession` call. Nothing reads a child's hint: the badge only needs its ACP title. `syncRunningSessionIds` now takes a second, title-only list; those trackers stop after the title is set and skip the display-root resolve and message polls. A tracker's mode follows the lists on every sync, so promoting an id to full fetches its whole transcript once. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
`githubRepo` and `subpath` were the lookup key for the child badge's repo tint, which 153c653 removed. Nothing read them since: the badge builder ignores them and the chat opener derives its repo label from the branch. Remove the fields and the `project_repos` join behind them, and reword the struct docs on both sides to say what the projection still carries, including that queued children are returned. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1007. Running children of a project session rode along in the live hint poller as full trackers, so each one cost a transcript fetch per 750 ms tick on top of the
getSessioncall. Nothing reads a child's hint: the badge only needs its ACP title.syncRunningSessionIdsnow takes a second, title-only id list. Those trackers stop after the title is set and skip the display-root resolve and message polls. A tracker's mode follows the lists on every sync, so promoting an id to full fetches its whole transcript once.ProjectSectionpasses running children through the title-only list.githubRepo/subpathfields fromChildSessionInfo(their only consumer, the badge repo tint, was removed in 153c653) along with theproject_reposjoin behind them.Test plan
liveSessionHintstests cover title-only trackers (no transcript fetch, promotion to full, demotion clears the hint)ChildSessionInfo🤖 Generated with Claude Code