Repository navigation
Conversation
…binaries Severity: CRITICAL Vulnerability: Shell agent validation could be bypassed for restricted binaries (like `rm`, `sudo`, etc.) when used as subcommands (e.g. `npm run rm`). This happened because the joined command string didn't perfectly match the `BLOCKED_TOKENS` whitespace expectations (e.g. `"rm "` vs `"rm"` at the end of the string). Impact: Allowed bypassing shell security restrictions to run potentially destructive commands through valid package manager wrappers. Fix: Added explicit token-by-token exact matching to catch restricted binaries regardless of their position in the command arguments. Verification: Covered by new exact match tests in the workdir_cmd tests module. Co-authored-by: bobdivx <6737167+bobdivx@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing as a duplicate: #283 already covers the same command validation bypass in workdir_cmd.rs and is kept open for review (security-sensitive). |
🛡️ Sentinel: [CRITICAL] Fix command validation bypass for restricted binaries
🚨 Severity: CRITICAL
💡 Vulnerability: Shell agent validation could be bypassed for restricted binaries (like
rm,sudo, etc.) when used as subcommands (e.g.npm run rm). This happened because the joined command string didn't perfectly match theBLOCKED_TOKENSwhitespace expectations (e.g."rm "vs"rm"at the end of the string).🎯 Impact: Allowed bypassing shell security restrictions to run potentially destructive commands through valid package manager wrappers.
🔧 Fix: Added explicit token-by-token exact matching to catch restricted binaries regardless of their position in the command arguments.
✅ Verification: Covered by new exact match tests in the
workdir_cmdtests module. Verified bycargo test -p devforge-agent --lib tools::workdir_cmd::tests.PR created automatically by Jules for task 3349846465414228437 started by @bobdivx