Repository navigation
Conversation
…ation
Previously, `validate_command` only checked if a padded token (e.g., `rm `)
was in the joined command string. This allowed malicious payloads like `npm run rm`
where the exact token had no trailing space to bypass the check.
This commit adds a loop to iterate through every parsed token and verifies exact
matches against sensitive binaries ("rm", "sudo", "chmod", "chown", "curl", "wget", "ssh", "scp").
Co-authored-by: bobdivx <6737167+bobdivx@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing as a duplicate: #283 already covers the same command validation bypass in workdir_cmd.rs and is kept open for review (security-sensitive). |
Understood. Acknowledging that this work is a duplicate and stopping work on this task. |
🚨 Severity: CRITICAL
💡 Vulnerability: Command validation in
workdir_cmd.rsrelied on joined strings for multi-word blocked phrases (rm), which allowed an attacker to bypass it by placing the sensitive token at the end of the command string without a trailing space (e.g.,npm run rm).🎯 Impact: Allowed execution of blocked commands like
rmandsudoin the workdir.🔧 Fix: Added explicit exact token match checks for sensitive binaries in
validate_command.✅ Verification: Run
cargo test -p devforge-agent --lib tools::workdir_cmd::testsand observe the new test passes.PR created automatically by Jules for task 9622733287554093035 started by @bobdivx