Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command validation bypass in workdir_cmd - #316

Closed
bobdivx wants to merge 1 commit into
mainfrom
sentinel-fix-command-bypass-13555328786545318873
Closed

bobdivx wants to merge 1 commit into
mainfrom
sentinel-fix-command-bypass-13555328786545318873

Conversation

@bobdivx

@bobdivx bobdivx commented Nov 9, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Command validation in tools::workdir_cmd checked for blocklist terms only on the joined command string. This allowed for bypasses like npm run rm because it bypassed the "rm " substring check, which was intended to block the rm command.
🎯 Impact: This could allow a malicious user to execute arbitrary commands or potentially delete files within the project working directory by chaining valid binaries with exact matches of sensitive binaries (e.g., npm run rm).
πŸ”§ Fix: Validates both the joined string for multi-word blocks AND individual tokenized arguments for exact matches of sensitive binaries (rm, sudo, chmod, chown, curl, wget, ssh, scp). Added unit tests to ensure these exact token bypasses are correctly blocked.
βœ… Verification: Ran cargo test -p devforge-agent --lib tools::workdir_cmd::tests which includes new test cases for npm run rm, npm test sudo, etc. All tests passed successfully.


PR created automatically by Jules for task 13555328786545318873 started by @bobdivx

Co-authored-by: bobdivx <6737167+bobdivx@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@bobdivx

bobdivx commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

Closing as a duplicate: #283 already covers the same command validation bypass in workdir_cmd.rs and is kept open for review (security-sensitive).

@bobdivx bobdivx closed this Nov 9, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor

Closing as a duplicate: #283 already covers the same command validation bypass in workdir_cmd.rs and is kept open for review (security-sensitive).

Understood. Acknowledging that this work is now obsolete as it is a duplicate of #283, and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant