Repository navigation
fix: make indexed_range::accessor move constructible - #444
Merged
Merged
Conversation
libc++ 21 implements std::generate with a lambda that takes the dereferenced iterator by value through an identity projection. This needs an accessible move constructor on the accessor proxy, so indexed_test failed to compile with Apple clang 21. The copy constructor stays private. Assisted-by: ClaudeCode:claude-fable-5-1
henryiii
commented
Oct 11, 2026
Collaborator
|
lgtm, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current macOS libc++ is broken. Claude wanted to fix it by making the private copy constructor public, I added a public move constructor instead, since that will keep the original intent to make copying a named accessor an error while also restoring
std::generatesupport which now needsauto x = *itto work. Let me know if you'd like anything different.🤖 AI text below 🤖
libc++ 21 (Apple clang 21) implements
std::generatewith a lambda that takesdecltype(*first)by value, after passing it through an identity projection. For a proxy reference type this needs an accessible move constructor.indexed_range::accessoronly had a private copy constructor, soindexed_testfailed to compile ondevelop.This adds a public move constructor to the accessor. The copy constructor stays private, so a named accessor still cannot be copied. The doc comment and changelog are updated.