Repository navigation
Conversation
Collaborator
|
Thanks! I had to resolve a merge conflict, and did it locally and then pushed that. So I'm closing this PR without a merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing
U"ab"withchar_ >> char_into astd::u32stringsucceeds but leaves onlyU"b": each character uses scalar assignment and replaces the previous contents. Extend the existingstd::stringexception tostd::u32stringandstd::u8stringso these elements are appended, including UTF-32-to-UTF-8 transcoding.The regression covers narrow and UTF-32 input, non-BMP code points, and UTF-8 output. Direct builds of
github_issues.cpppass with GCC 12 (C++17/20) and Clang 14/19 (C++20); GCC checks for sequence attributes, parser attributes, and merging also pass. These local checks use Boost 1.74 support headers.CI is incomplete. GitHub Actions awaits maintainer approval; all five workflows have zero jobs. Drone finished with 21 successful, 10 failed and four terminated stages. Its Clang 14/C++20
compile_all_tfailure reproduces identically on unmodifieddevelopat293f5e1; other stages report relatedall_t/ranges diagnostics (see #323). The Xcode 14.0 runner exits with an unaccepted Xcode license. The Xcode 15.0.1 failure and terminated stages have not been fully diagnosed.Fixes #327.