Repository navigation
docs: promote TTL-inline cross-leader design to partial - #1338
Conversation
…rtial #1280 merged the first M1 and M1b components to main (physical-page reporting, the shared delta/migration rotation, the capability-gated absence guard, and the durable generation-pin journal with its typed FSM commands), while M1 reporting integration, M1b activation and M2-M4 remain open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M143Q9MNkB4QTCD4Zbd1M8 Signed-off-by: Claude <noreply@anthropic.com>
Update the implementation progress of the now-partial design: the M1 and M1b components listed are on main via #1280, no milestone is complete, and the new protocol stays disabled. Record the proposal-time require_absent refusal in TransactionManager.Commit and that M1b's all-member capability fence is what replaces it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M143Q9MNkB4QTCD4Zbd1M8 Signed-off-by: Claude <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
設計状態と実装進捗の記録 docs/design/2026_10_17_partial_ttl_inline_cross_leader_legacy_rows.md |
文書の状態をPartialに変更しました。M1の物理ページ報告とM1bの原子的な不在条件を実装済みとして記載し、耐久性のある能力・有効化フェンスなどの未完了項目を明記しました。 |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Possibly related issues
bootjp/elastickv#1330— 同じ設計文書と残作業を扱います。このPRは進捗を記録しますが、Issueの実装項目は完了しません。
Possibly related PRs
- bootjp/elastickv#1090 — capability gate、readiness、Raft FSMの適用制御を実装しており、文書に記載されたM1bの能力フェンスと関連します。
- bootjp/elastickv#1280 — 同じTTL-inline移行設計を追加し、このPRはその設計文書の進捗を更新します。
Merge Risk: 
Minimal · up to 8dcec
-
This PR only updates design-document status and progress, with no identified merge-blocking risk.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Design: docs/design/2026_10_17_partial_ttl_inline_cross_leader_legacy_rows.md
Summary
Renames the design doc from
proposedtopartial. #1280 merged the first M1 and M1b components to main, and the README definespartialas "some components exist but the full scope is not yet merged".There are two commits:
git mv): the dedicated promotion commit the README asks for. It changes only the filename and theStatus:header.TransactionManager.Commitnow refusesrequire_absentbefore proposing it, and M1b's all-member capability fence is what replaces that refusal.The
2026_10_17date and the headerDate:are unchanged, as the README requires. Nothing else in the repository links to the old filename.Evidence that the doc is partial, not implemented
ShardStore.ScanGroupOwnedPageAt(kv/legacy_metadata_scan.go)adapter/redis_background_rotation.go)kv/absence_guard.go, includingrefuseAbsenceProposal)kv/fsm_replicated_backup.go,kv/replicated_backup_codec.go)requireLegacyCompactionStateinkv/compactor.go)RelocateLegacyRows(M2),PurgeShadowedVersions/RaiseReadFloor(M3), the M4 gate, and M1 reporting integration and M1b activation.Self-review
Docs only: no code, wire-format or test changes.
All commits carry
Signed-off-byfor DCO.Generated by Claude Code
Summary by CodeRabbit
require_absentを含む要求は、全メンバーの能力を永続的に確認できるようになるまで、提案前に拒否する方針を明記しました。