Repository navigation
Carry a time that rounds to midnight into the date exactly once - #107
Merged
Merged
Conversation
Fixes borgar#104 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
yyyy-mm-dddidn't carry at0.99999999999(gave1900-01-00), andyyyy-mm-dd hh:mm:sscarried twice at45000.99999999999(gave2023-03-17 00:00:00). Excel gives1900-01-01/1900-01-01 00:00:00and2023-03-16/2023-03-16 00:00:00.Fix (
src/runPart.ts):m/d/yyat45292.99999999→1/1/24behaviour is unchanged.toYMDwasvalue + date - trunc(value). Adding in floating point rounded45001.99999999999up to45002, which caused the second carry. It is nowfloor(value) + date - trunc(value), an integer computed exactly.Tests: added a case to
test/numfmt.spec.tswith the four values from the issue. It fails before the fix and passes after. The fullnpm testsuite, eslint and tsc are clean.Fixes #104
AI-assisted (Claude); reviewed before submission.