Repository navigation
Fix the whole part of vulgar fractions - #110
Merged
Merged
Conversation
The whole part was rounded to one decimal before flooring, so 2.96 in # ??/16 printed as 3 15/16. A fraction rounding up to 1 now carries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The whole part of a fraction format was rounded to one decimal before flooring, so
format('# ??/16', 2.96)gave3 15/16, which reads as 3.94. The fraction also didn't carry:format('# ?/2', 1.75)gave1 2/2.The whole part is now floored from the value, and a fraction that rounds to 1 carries into it:
2 15/16and2, same as Excel. Two new assertions fail without the change.vitest runwith the Excel tables passes (53082 tests).