Repository navigation
feat(ui): add PWA launch veil and skeleton loading states - #17
Merged
Merged
Conversation
- Show a theme-matched launch veil only in installed/standalone PWAs; it fades out after the first content frame and is never rendered in a browser tab, so it cannot regress browser LCP - Replace toast-only feed loading with delayed skeleton cards: 150 ms delay when cards are already visible, immediate on an empty grid; replace loads snapshot and restore the previous grid on failure, View more appends three skeleton rows - Crossfade skeleton/content through the View Transitions API with a Web Animations fallback; disable shimmer and transitions under prefers-reduced-motion - Add aria-busy on the grid, aria-hidden skeleton cards, and a visually hidden live status region for loading messages - Suppress the browser's native type=search clear control so only the app's search toggle/close button remains - Bump app.js to v107 and the service-worker shell cache to v141; add render hook tests and update README/ARCHITECTURE/DEPLOYMENT/RUNBOOK Verified: 87 tests, typecheck, wrangler dry-run, 0 audit findings; browser and standalone launch states, replace/append skeletons, failed-load restore, view-transition usage, reduced-motion behavior, and search-field rendering were exercised in Chrome DevTools. Co-Authored-By: Claude Code <noreply@anthropic.com>
|
🔎 Cloudflare preview: https://3b6149f0-feedreader.phatpham9.workers.dev Uploaded from |
- Keep the card title visible while a preview loads and replace the visible "Loading preview…" text with a preview skeleton after 150 ms - Hide the loading status visually (sr-only) but keep it in the live region; clear the skeleton on completion, abort, or failure - Fade the updated preview title and loaded content in; respect reduced motion and skip all view/Web Animations when requested - Add preview skeleton styles and bump app.js to v108 / shell cache to v142 - Update README, ARCHITECTURE, and RUNBOOK Verified in Chrome DevTools: delayed skeleton with card title, skeleton removal and 30 rendered content blocks on success, focused error state on failure, and zero skeleton/WAAPI animation under prefers-reduced-motion. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PWA launch experience
app.jsfades the veil out after the first content frame and removes it from the DOM. Browser tabs never display it, so it cannot affect browser LCP.theme-init.js(display-mode: standaloneplus iOSnavigator.standalone).Feed skeleton loading and transitions
View moreappends three skeleton rows at the bottom.prefers-reduced-motion: reducedisables shimmer, view transitions, and Web Animations while keeping the state changes.aria-busy, skeleton cards arearia-hidden, and a visually hidden live region announces loading messages.Article preview loading state
sr-only); it becomes visible again only for the empty/error messages.prefers-reduced-motion.Search field
type="search"clear control so the app's search toggle/close button is the only clear affordance. Typing in the field no longer shows a second X.Housekeeping
app.jsto v108 and the service-worker shell cache toreader-shell-v142.core/test/render.spec.ts) and updated README, ARCHITECTURE, DEPLOYMENT, and RUNBOOK.Verification
npm run typechecknpm test— 87 passingnpm run db:migrate:localwrangler deploy --dry-runnpm audit— 0 vulnerabilitiesdisplay: none, then removed from the DOMdata-standalone="true", veil computeddisplay: grid, removed after the fadearia-busy=true, live statusSearching feed…, then 12 real cardsView more: 12 real cards + 3 skeleton rows, then 24 real cardsaria-busy=falseanimation-name: none, zero view-transition and WAAPI callsNotes
🤖 Generated with Claude Code