Repository navigation
fix(pwa): use "reader." consistently in app metadata - #20
Merged
Merged
Conversation
The in-app wordmark already renders "reader." (header and launch veil), but the browser tab title, Open Graph/Twitter titles, application-name, and Apple/Android installed-app metadata dropped the dot. iOS uses apple-mobile-web-app-title (with the manifest as fallback), so adding the app to the home screen showed "reader". - Use "reader." in <title>, application-name, og:site_name, og:title, twitter:title, and apple-mobile-web-app-title - Set manifest name and short_name to "reader." - Bump the manifest/app.js asset stamps and SHELL_CACHE so installed clients install the updated manifest - Lock the metadata with a render test Co-Authored-By: Claude Code <noreply@anthropic.com>
|
🔎 Cloudflare preview: https://30105c11-feedreader.phatpham9.workers.dev Uploaded from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The in-app wordmark already renders
reader., but every OS/browser identity field dropped the dot. iOS readsapple-mobile-web-app-title(manifest as fallback), so Add to Home Screen producedreader.The manifest and
app.jsstamps plusSHELL_CACHEare bumped because the manifest is servedimmutableand pre-cached, so installed clients would otherwise keep the old name. Internal identifiers (feedreaderWorker/D1/user-agent) and prose uses such as “reader view” / “Reader settings” are intentionally unchanged.Evidence
AssertionError: expected '<!doctype html>…' to contain '<title>reader.</title>'(rendered<title>reader</title>).After:
npm test→ 12 files, 88 tests passed;npm run typecheck→ exit 0.Rendered head after the change:
Manifest parse:
{"name":"reader.","short_name":"reader."}Merge Danger
Door: two-way — a revert is a normal deploy; no data or schema changes.
Blast Radius: low — installed-app/browser metadata only.
Existing iOS home-screen icons keep the label captured when they were added; users must remove and re-add to see
reader.. Web APK/desktop installs pick up the manifest on update.🤖 Generated with Claude Code