Skip to content

fix(pwa): use "reader." consistently in app metadata - #20

Merged
phatpham9 merged 1 commit into
mainfrom
fix/reader-name-consistency
Nov 13, 2026
Merged

phatpham9 merged 1 commit into
mainfrom
fix/reader-name-consistency

Conversation

@phatpham9

Copy link
Copy Markdown
Member

Summary

The in-app wordmark already renders reader., but every OS/browser identity field dropped the dot. iOS reads apple-mobile-web-app-title (manifest as fallback), so Add to Home Screen produced reader.

 core/render.ts
-<title>reader</title>
+<title>reader.</title>
-<meta name="application-name" content="reader" />
+<meta name="application-name" content="reader." />
-<meta property="og:site_name" content="reader" />
+<meta property="og:site_name" content="reader." />
-<meta property="og:title" content="reader — engineering and research signals" />
+<meta property="og:title" content="reader. — engineering and research signals" />
-<meta name="twitter:title" content="reader — engineering and research signals" />
+<meta name="twitter:title" content="reader. — engineering and research signals" />
-<meta name="apple-mobile-web-app-title" content="reader" />
+<meta name="apple-mobile-web-app-title" content="reader." />
-<link rel="manifest" href="/site.webmanifest?v=17" />
+<link rel="manifest" href="/site.webmanifest?v=18" />

 web-static/site.webmanifest
-  "name": "reader",
-  "short_name": "reader",
+  "name": "reader.",
+  "short_name": "reader.",

 web-static/service-worker.js
-const SHELL_CACHE = "reader-shell-v142";
+const SHELL_CACHE = "reader-shell-v143";

The manifest and app.js stamps plus SHELL_CACHE are bumped because the manifest is served immutable and pre-cached, so installed clients would otherwise keep the old name. Internal identifiers (feedreader Worker/D1/user-agent) and prose uses such as “reader view” / “Reader settings” are intentionally unchanged.

Evidence

  • Before: the new test failed with AssertionError: expected '<!doctype html>…' to contain '<title>reader.</title>' (rendered <title>reader</title>).
    After: npm test → 12 files, 88 tests passed; npm run typecheck → exit 0.

Rendered head after the change:

<title>reader.</title>
<meta name="application-name" content="reader." />
<meta property="og:site_name" content="reader." />
<meta property="og:title" content="reader. — engineering and research signals" />
<meta name="twitter:title" content="reader. — engineering and research signals" />
<meta name="apple-mobile-web-app-title" content="reader." />
<link rel="manifest" href="/site.webmanifest?v=18" />
<script src="/static/app.js?v=109" defer></script>

Manifest parse: {"name":"reader.","short_name":"reader."}

Merge Danger

Door: two-way — a revert is a normal deploy; no data or schema changes.

Blast Radius: low — installed-app/browser metadata only.

Existing iOS home-screen icons keep the label captured when they were added; users must remove and re-add to see reader.. Web APK/desktop installs pick up the manifest on update.

🤖 Generated with Claude Code

The in-app wordmark already renders "reader." (header and launch veil), but the browser tab title, Open Graph/Twitter titles, application-name, and Apple/Android installed-app metadata dropped the dot. iOS uses apple-mobile-web-app-title (with the manifest as fallback), so adding the app to the home screen showed "reader".

- Use "reader." in <title>, application-name, og:site_name, og:title, twitter:title, and apple-mobile-web-app-title
- Set manifest name and short_name to "reader."
- Bump the manifest/app.js asset stamps and SHELL_CACHE so installed clients install the updated manifest
- Lock the metadata with a render test

Co-Authored-By: Claude Code <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🔎 Cloudflare preview: https://30105c11-feedreader.phatpham9.workers.dev

Uploaded from 35dec0817585a096609f2dccb33f4b4d07c00bbb. This is a Worker version preview — it shares the production D1 database, so it reads/writes real data; it does not receive cron-triggered refreshes.

@phatpham9
phatpham9 merged commit 913b58c into main Nov 13, 2026
3 checks passed
@phatpham9
phatpham9 deleted the fix/reader-name-consistency branch November 13, 2026 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant