Repository navigation
fix(preview): hide provisional title while the skeleton loads - #28
Merged
Merged
Conversation
Card titles and fetched article titles often differ, so showing the card title under the reader skeleton made the panel look like it had loaded the wrong article. When the delayed preview skeleton appears, hide the provisional title and start the skeleton with a title placeholder, followed by byline/body rhythm. The provisional title stays visible for the first 150ms so fast responses swap straight to the fetched title without a blank flash. Success reveals the fetched title; failures restore the card title and show the error status. Bump app.js to v111 and the PWA shell cache to v145. Co-Authored-By: Claude Code <noreply@anthropic.com>
|
🔎 Cloudflare preview: https://b04ab2ba-feedreader.phatpham9.workers.dev Uploaded from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Card titles and fetched article titles often differ, so showing the card title under the reader skeleton made the panel look like it had loaded the wrong article.
app.jstov111and the PWA shell cache tov145.Verification
npm run typechecknpx vitest run --exclude '.claude/**'— 18 files, 148 testsnode --check web-static/static/app.jsdisplay: none/is-preview-loading, skeleton present, card title hidden502 blocked: skeleton cleared, card title restored, readable error status shown/static/app.js?v=111; render tests expectv111.Notes
🤖 Generated with Claude Code