Repository navigation
fix(preview): show the reader skeleton immediately - #29
Merged
Merged
Conversation
The 150ms preview skeleton delay let the provisional card title flash before the skeleton, even though the fetched article title usually differs. Show the skeleton immediately on open and hide the provisional title from the first frame, so the panel only ever shows a title placeholder until the fetched title arrives. Feed skeletons keep their 150ms delay; this only changes the reader panel. Success reveals the fetched title; failures restore the card title and error status. Bump app.js to v112 and the PWA shell cache to v146. Co-Authored-By: Claude Code <noreply@anthropic.com>
|
🔎 Cloudflare preview: https://3bfd0aa4-feedreader.phatpham9.workers.dev Uploaded from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 150ms preview skeleton delay still let the provisional card title flash before the skeleton, even though the fetched article title usually differs. This shows the skeleton immediately on open and hides the provisional title from the first frame:
app.jstov112and the PWA shell cache tov146.Verification
npm run typechecknpx vitest run --exclude '.claude/**'— 18 files, 148 testsnode --check web-static/static/app.jsdisplay: none/is-preview-loading, skeleton already present, card title hidden/static/app.js?v=112; render tests expectv112.Notes
🤖 Generated with Claude Code