Repository navigation
Conversation
Co-authored-by: pylipp <10617122+pylipp@users.noreply.github.com>
Co-authored-by: pylipp <10617122+pylipp@users.noreply.github.com>
Co-authored-by: pylipp <10617122+pylipp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the project from PHP 8.2 to 8.4. Also fix the two runtime deprecations in the app code:
E_USER_ERRORpassed totrigger_error, andfputcsvwithout an explicit$escapeargument.Version bump
.docker/php/Dockerfile:php:8.4-apache, and xdebug3.3.1→3.4.5(3.3.x doesn't support 8.4).circleci/config.yml:cimg/php:8.4-browsers(image tag only)app.yaml:runtime: php84README.md,copilot-setup-steps.yml,copilot-instructions.mdand the dependabot skill doc now say 8.4rector.phpis still onphp82: trueon purpose, so Rector doesn't start rewriting code in this PRE_USER_ERROR→E_USER_WARNINGtrigger_errorcalls, ininclude/people.php,include/stock_edit.php,library/lib/auth0.php(2),library/lib/errorhandling.php,library/ajax/testdbdelete.php(2),library/functions.phpandcron/dailyroutine.phpboxwise_error_handler_classfputcsv: both calls incron/reseed-roles-auth0.phpnow pass',', '"', ''explicitlyReviewer notes
E_USER_ERRORwith PHP's default handler aborts the script, so the code after each call (throw,$return = 'false',redirect(),logoutWithRedirect()) was effectively unreachable. WithE_USER_WARNINGthat code now runs.mobile_distro_checknow redirects after logging.dailyroutineloop now checks every Auth0 user instead of stopping at the first mismatch.$escapefollows RFC 4180. A backslash inside a value is no longer treated as an escape character. This only matters if a role name contains one.google/cloud-coregoogle/cloud-datastoregoogle/cloud-error-reportinggoogle/cloud-loggingopencensus/opencensussendgrid/sendgridopencensus/opencensusandopencensus/opencensus-exporter-stackdriverare abandoned.