Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion curtsies/formatstringarray.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def __getitem__(
) -> FmtStr | list[FmtStr]:
if isinstance(slicetuple, int):
if slicetuple < 0:
slicetuple = len(self.rows) - slicetuple
slicetuple = len(self.rows) + slicetuple
if slicetuple < 0 or slicetuple >= len(self.rows):
raise IndexError("out of bounds")
return self.rows[slicetuple]
Expand Down
20 changes: 20 additions & 0 deletions tests/test_fmtstr.py
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,26 @@ def test_width_awareness(self) -> None:


class TestFSArray(unittest.TestCase):
def test_negative_row_indices(self) -> None:
a = fsarray([red("first"), blue("middle"), green("last")])
for index in range(-len(a), len(a)):
with self.subTest(index=index):
self.assertIs(a[index], a.rows[index])

a[2] = red("new")
self.assertEqual(a[-1], red("new"))
self.assertIs(a[-1], a[2])
self.assertEqual(a[:-1], a.rows[:-1])
self.assertEqual(a[-1:], a.rows[-1:])

def test_row_indices_out_of_bounds(self) -> None:
for rows in ([], ["a"], ["a", "b", "c"]):
a = fsarray(rows)
for index in (-len(a) - 1, len(a)):
with self.subTest(rows=rows, index=index):
with self.assertRaises(IndexError):
_ = a[index]

def test_no_hanging_space(self) -> None:
a = FSArray(4, 2)
self.assertEqual(len(a.rows[0]), 0)
Expand Down
Loading