credential chain - #464
Merged
Merged
Conversation
patelspratik
force-pushed
the
pr2-credential-chain
branch
from
August 27, 2026 15:34
3b2b051 to
f8d0e25
Compare
patelspratik
force-pushed
the
pr2-credential-chain
branch
from
August 27, 2026 15:45
f8d0e25 to
bda151d
Compare
patelspratik
force-pushed
the
pr2-credential-chain
branch
from
August 27, 2026 18:36
bda151d to
3c8b255
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
==========================================
+ Coverage 24.67% 29.09% +4.42%
==========================================
Files 134 140 +6
Lines 18337 19809 +1472
==========================================
+ Hits 4525 5764 +1239
- Misses 13335 13462 +127
- Partials 477 583 +106
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
patelspratik
force-pushed
the
pr2-credential-chain
branch
from
August 27, 2026 21:07
3c8b255 to
f243f41
Compare
drewmalin
reviewed
Aug 27, 2026
Comment on lines
177
to
180
| // Verify the user is authenticated before performing any local side effects. | ||
| if _, err := s.GetCurrentUser(); err != nil { | ||
| return breverrors.WrapAndTrace(err) | ||
| } |
Contributor
There was a problem hiding this comment.
Only do this if we're in the normal non-key mode?
Contributor
Author
There was a problem hiding this comment.
this should really be something like "isAuthenticated". I'll fix this with a better sentinel.
patelspratik
force-pushed
the
pr2-credential-chain
branch
2 times, most recently
from
August 28, 2026 23:05
a7dfe8c to
92c34a0
Compare
Rebased onto pr1-register-resiliency (post ssh-certs uptake). - BREV_ACCESS_KEY renamed to BREV_API_KEY (never released); all access-key identifiers and messages renamed to API key - Env-key orgs resolve in real time from the backend: the key is bound to exactly one org server-side, so no persisted org is consulted and staleness is impossible. Established logins keep persisted org behavior (APIKeyOrgID / active-org cache) - Single-org invariant hoisted to auth.SingleOrgForAPIKey, shared by register and the general resolution path - GetActiveOrganizationOrNil branches on credential source; env path returns the full org (name included) without a second GetOrganization round-trip - Register with no env key and no persisted credential now prompts the device-flow login (externalNodeAuth fallback) instead of erroring; tokens stay in memory, the login email is cached for pre-fill - Register tests moved/renamed to the APIKey convention
patelspratik
force-pushed
the
pr2-credential-chain
branch
from
August 28, 2026 23:43
92c34a0 to
6944cc9
Compare
patelspratik
marked this pull request as ready for review
August 29, 2026 00:01
patelspratik
commented
Aug 29, 2026
Contributor
Author
There was a problem hiding this comment.
this is very stupid and all because we do a singular automatic retry in our resty client, which prints errors automatically/uncontrollably.
I'd like to remove that, but it is a nice feature to try automatically renew stale creds, so I left that and this.
drewmalin
reviewed
Aug 31, 2026
Comment on lines
+23
to
+26
| // A declined login prompt is not an error | ||
| if stderrors.Is(err, &breverrors.DeclineToLoginError{}) { | ||
| return | ||
| } |
drewmalin
reviewed
Aug 31, 2026
Comment on lines
+165
to
+170
| func SingleOrgForAPIKey(orgs []entity.Organization) (*entity.Organization, error) { | ||
| if len(orgs) != 1 { | ||
| return nil, breverrors.New("api key invalid") | ||
| } | ||
| return &orgs[0], nil | ||
| } |
Contributor
There was a problem hiding this comment.
This feels like a funny function -- can we just have the below determine if the API key is valid?
drewmalin
reviewed
Aug 31, 2026
Comment on lines
+173
to
+175
| // login is an explicit action. Clear BREV_API_KEY so the freshly-saved JWT | ||
| // authenticates post-login calls (GetCurrentUser, org selection, etc.) | ||
| // GetFreshAccessTokenOrNil returns the env key before consulting saved credentials. |
Contributor
There was a problem hiding this comment.
Interesting, so this means that this would be the rare command where the BREV_API_KEY=bak-abc123 brev login basically ignores the env var...
drewmalin
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.