fix(browser): reject pending calls on invalidation - #155
Open
green3sf wants to merge 1 commit into
Open
Conversation
green3sf
marked this pull request as ready for review
August 19, 2026 10:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #154
Type of change
What does this PR do?
Session.invalidate()removed the active socket before its close handler ran, so the handler treated the socket as superseded and left in-flight CDP calls pending.Rejecting and clearing the pending calls during invalidation makes them settle with the same retirement error.
How did you verify your code works?
git diff --checkpasses.Screenshots / recordings
Not applicable.
Checklist
Summary by cubic
Rejects in-flight CDP calls when a session is invalidated to prevent hangs. Previously,
Session.invalidate()removed the socket before its close handler ran, leaving pending calls unresolved; now it rejects and clears all pending calls with the same retirement error.Written for commit 6fbf5db. Summary will update on new commits.