fix(rca): view-report link uses canonical observability_url (correct TFA sub-tab on load) - #374
Open
Dave3130 wants to merge 2 commits into
Open
fix(rca): view-report link uses canonical observability_url (correct TFA sub-tab on load)#374Dave3130 wants to merge 2 commits into
Dave3130 wants to merge 2 commits into
Conversation
QA: the terminal report URL used the build-UUID form (/builds/<uuid>?tab=ai_report&subTab=tfa),
which 302-redirects to the canonical dashboard path and the redirect drops the query
string — so the dashboard loads the default sub-tab, not TFA, forcing a manual switch.
Resolve viewReport to the build's canonical observability_url (projects/<name>/builds/<name>/<n>)
+ tab=ai_report&subTab=tfa via one GET /ext/v1/builds/{uuid} (trigger response is a lean
ack with no URL); fall back to the UUID form only if that read fails. Also align subTab
to tfa across the UUID fallback + RESOLVED-turn guidance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (QA)
The TFA report link shown in the terminal used the build-UUID form:
…/builds/<buildUuid>?tab=ai_report&subTab=tfa. That URL 302-redirects to the canonical dashboard path, and the redirect drops the query string — so the dashboard loads its default sub-tab instead of the TFA report, and the user has to manually switch tabs on the UI.Fix
Resolve
viewReportto the build's canonicalobservability_url(…/projects/<name>/builds/<name>/<n>) +?tab=ai_report&subTab=tfa. The canonical URL doesn't redirect, so the query sticks and the TFA sub-tab loads directly.trigger-report.ts—resolveViewReport()readsobservability_urlvia oneGET /ext/v1/builds/{uuid}(the release-readiness trigger response is a lean ack —{state, buildUuid, triggeredAt}— with no URL, confirmed live). Falls back to the UUID deep-link only if that read fails.constants.ts— addedAI_REPORT_TFA_QUERY+BUILD_DETAILS_PATH; alignedsubTabtotfa(confirmed correct) on the UUID fallback + the RESOLVED-turn guidance.Targets
TRA_TFA. (Needs a ticket link — QA report-URL feedback.)