Repository navigation
Conversation
Bumps the cargo-minor-patch group with 1 update: [self-replace](https://github.com/mitsuhiko/self-replace). Updates `self-replace` from 1.5.0 to 1.5.1 - [Changelog](https://github.com/mitsuhiko/self-replace/blob/main/CHANGELOG.md) - [Commits](mitsuhiko/self-replace@1.5.0...1.5.1) --- updated-dependencies: - dependency-name: self-replace dependency-version: 1.5.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-patch ... Signed-off-by: dependabot[bot] <support@github.com>
The existing update test swaps in a sentinel on every OS. On Windows, self-replace is not a rename (the running .exe is moved aside and a helper deletes the leftovers), so add a Windows-only test that swaps in a real binary and checks the replaced .exe launches, that it can update again over a file a self-replace put there, and that nothing is left in its directory afterwards. Run it as a dedicated check on both Windows architectures so a bump of self-replace or windows-sys (e.g. #97) fails by name. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WeiJxQWhjhQvvURAjiDkti
…ch-9cf12090d2' into tmp/verify-97
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway: PR #100's tests plus #97's Cargo.lock, to run the Windows self-update checks against the bumped dependency. Will be closed and its branch deleted.