Repository navigation
docs(ios): fix the SPM BugseeAgent path pattern and the existence check - #126
Merged
Merged
Conversation
- ${BUILD_DIR%Build/*} cut at any component ending in "Build". During Archive,
BUILD_DIR holds the scheme name, so a scheme like AppBuild gave
.../ArchiveIntermediates/AppSourcePackages. Use ${BUILD_DIR%/Build/*}/SourcePackages.
- [ ! "${SCRIPT_SRC}" ] tests for an empty string, which the SPM path never is, so a
wrong path ran python3 on a missing file and failed silently. Use [ ! -f ... ].
- The SPM tab's error names the path it tried instead of the framework-copy advice,
which applies only to the direct download.
Applies to symbolication, v6/symbolication and the build-size-analysis AI prompt.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Change-Id: I8500a5eb45ec36ecaf58ca6a450e858e3018fa34
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
Claude finished @dsheikherev's task in 29s —— View job Review of PR #126
I didn't run the build or cspell. I only read the diff, grepped the repo, and tested the parameter expansion in bash. Findings
Checks
Summary
|
krassx
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These are follow-ups to the
BugseeAgentpath fix from #119, insymbolication.mdx,v6/symbolication.mdxand the AI prompt inbuild-size-analysis.mdx.${BUILD_DIR%Build/*}cuts at the last path component that ends inBuild. During Archive,BUILD_DIRis.../Build/Intermediates.noindex/ArchiveIntermediates/<Scheme>/BuildProductsPath. A scheme such asAppBuildtherefore produced.../ArchiveIntermediates/AppSourcePackages. The pattern is now${BUILD_DIR%/Build/*}/SourcePackages/..., which matches only a component namedBuild.[ ! "${SCRIPT_SRC}" ]tests for an empty string. That works afterfind, but the SPM path is never empty. A wrong path ranpython3on a missing file, the error went to the post-action's stderr, and nothing was uploaded. The check is now[ ! -f ... ]in every script and prompt.Closes #121. The wrong
$BUILD_DIR/../path from that issue was fixed in #119; this PR fixes the always-false check.The agent skills get the same change in bugsee/bugsee-for-ai#30. The mirror under
docs/ai/agent-skillsis regenerated after that merges.Test plan
sh. With an ArchiveBUILD_DIRfor schemeAppBuild, the agent runs. With a wrong location, it printsError: BugseeAgent script not found at …and exits 1.npm run build: success🤖 Generated with Claude Code