Repository navigation
docs(ios): notify shipped in 6.3.0; 7.0.0-beta1 added urgent and the flush delay - #129
dsheikherev wants to merge 2 commits into
Conversation
…flush delay Bugsee.notify is public in Bugsee.h from 6.3.0 (four overloads; 6.2.1 has none), but the 6.3.0 notes did not list it, and the 7.0.0-beta1 notes presented notification relay as new. What 7.x added (bugsee-cocoa 178a9962, before beta1) is the urgent: overload and BugseeOptionConfigNotifyFlushDelay. - v6/release-notes.md: add notification relay to 6.3.0. - release-notes.md: the 7.0.0-beta1 entry names what is new and says notify shipped in 6.3.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Change-Id: Ia5082760dae7676fd0c3682949d3b8e8562a1b98
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
Claude finished @dsheikherev's task in 32s —— View job Review of PR #129
I did not run cspell or the build. The PR description says both passed. I also could not check the Findings1. P3,
2. P3, outside the diff,
Summary
|
| - Feat: Notification relay gains an `urgent:` overload, which posts the notification right away | ||
| instead of queueing it, and `BugseeOptionConfigNotifyFlushDelay`, which batches nearby | ||
| notifications into one upload. `Bugsee.notify` itself shipped in 6.3.0. |
There was a problem hiding this comment.
Severity: P3 Low
Location: docs/sdk/ios/release-notes.md:392-394
Problem: Two small accuracy gaps against the pages this entry summarizes.
- "posts the notification right away instead of queueing it" overstates it. notification-relay.mdx says an urgent notification skips the line ahead of the queue, but only if the SDK has a server session and the network is reachable (honoring
BugseeOptionConfigNotifyFlushDelay-independent Wi-Fi-only rules). Otherwise it is queued like any other, and delivery is at-least-once. BugseeOptionConfigNotifyFlushDelayis described as if batching is new.migration.mdx§9.4 says 6.x always waited a fixed one second and 7.x defaults to0, so the default flush behavior changed. A reader upgrading from 6.3.x would not learn that from this entry.
Impact: Readers may assume urgent notifications bypass the queue unconditionally, and may not realise default batching changed in 7.x.
Scenario: An app callsnotify(..., urgent: true)while offline. The release note suggests it was sent immediately, but it is queued.
Fix:
| - Feat: Notification relay gains an `urgent:` overload, which posts the notification right away | |
| instead of queueing it, and `BugseeOptionConfigNotifyFlushDelay`, which batches nearby | |
| notifications into one upload. `Bugsee.notify` itself shipped in 6.3.0. | |
| - Feat: Notification relay gains an `urgent:` overload, which skips ahead of the queue and posts that one | |
| notification right away when the network is available, and `BugseeOptionConfigNotifyFlushDelay`, which sets | |
| how long to wait before flushing the queue (default `0`; 6.x always waited one second). `Bugsee.notify` | |
| itself shipped in 6.3.0. |
There was a problem hiding this comment.
Applied in the latest commit, reflowed to the file's line width. Confirmed the 6.x behavior in the 6.3.0 source: BGSNotificationRelayManager.m has kRelayCoalesceDelay = 1.0.
…; 6.x waited one second Per review: an urgent notification skips the queue but is still queued while offline, and the flush delay changed the default, since 6.3.0 coalesced for a fixed second (kRelayCoalesceDelay = 1.0) and 7.x defaults to 0, as migration.mdx 9.4 says. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Change-Id: Ic09c234d37ba2ebd3051e5e9020bc61f6ad5246f
|
Claude finished @dsheikherev's task in 17s —— View job Re-review of PR #129 after the latest push (
|
Summary
The release notes got the history of
Bugsee.notifywrong.notifyis public inBugsee.hfrom 6.3.0, with four overloads (title; body; severity; fields). 6.2.1 has none. The 6.3.0 notes did not list it.178a9962(Aug 31, before beta1), is theurgent:overload andBugseeOptionConfigNotifyFlushDelay.Changes:
v6/release-notes.md: notification relay added to 6.3.0.release-notes.md: the 7.0.0-beta1 entry now names theurgent:overload and the flush delay, and saysnotifyitself shipped in 6.3.0.Test plan
npm run build: success🤖 Generated with Claude Code