Repository navigation
Conversation
…ndar support - Request contacts:read permission in manifest.json to allow reading the virtual contact birthday calendar and events from the host calendar API - Bump calendar-agenda version to 1.5.0 - Add unit test for birthday event rendering with configured birthday calendar color - Update documentation and changelog - Rebuild calendar-agenda.zip bundle
Contributor
Author
|
Superseded by #36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requests the
contacts:readpermission in thecalendar-agendamanifest to display contact birthdays from Bulwark's virtual birthday calendar (__birthday-calendar__).Under bulwarkmail/webmail#1479, virtual birthday events and the birthday calendar exposed via
api.calendarrequire the calling plugin to holdcontacts:readin addition tocalendar:readfor privacy protection.Changes
"contacts:read"tocalendar-agenda/manifest.json.1.5.0acrossmanifest.json,package.json, andpackage-lock.json.calendar-agenda.zip, updatedCHANGELOG.md, and updated permission descriptions incalendar-agenda/README.mdand rootREADME.md.calendar-agenda/test/agenda.test.mjsasserting that thecontacts:readpermission is declared and that birthday events with the birthday calendar color are rendered correctly.Testing
npx vitest run calendar-agendapassed (84/84 tests).node scripts/check.mjs calendar-agendapassed cleanly.node scripts/build.mjs --check calendar-agendapassed cleanly (zip is in sync).