Repository navigation
fix(smime): preserve terminal CRLF in detached signed MIME entities - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MIME serializers can append CRLF after multipart closing delimiters, changing the bytes covered by a detached S/MIME signature. The original MIME framing is standards-compliant and the original signatures verify cryptographically; reserialization can nevertheless invalidate them.
Terminate newly generated detached MIME entities before CMS signing, retaining a separate outer boundary framing CRLF. Apply the same treatment to nested multipart/alternative inside multipart/mixed. Historical signature verification and opaque/encrypted generation remain unchanged.
Validation: 17 focused tests pass, including OpenSSL S/MIME and exact-entity CMS verification, byte-identical Python MIME serialization round-trips, and boundary framing checks. The plugin build passes. External-client interoperability was manually confirmed after deploying this patch.